doc,test: clarify --eval syntax for leading '-' scripts#62244
Closed
kovan wants to merge 1 commit intonodejs:mainfrom
Closed
doc,test: clarify --eval syntax for leading '-' scripts#62244kovan wants to merge 1 commit intonodejs:mainfrom
kovan wants to merge 1 commit intonodejs:mainfrom
Conversation
If the script passed to --eval starts with a hyphen, the CLI parser treats it as another option flag. Document the --eval=<script> form as the workaround and add tests for --eval=-42, --eval=-0, and the -e -p missing-argument error. Refs: nodejs#43397 Continues the work from nodejs#61962
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62244 +/- ##
==========================================
- Coverage 89.67% 89.67% -0.01%
==========================================
Files 676 676
Lines 206469 206469
Branches 39537 39532 -5
==========================================
- Hits 185157 185154 -3
- Misses 13448 13469 +21
+ Partials 7864 7846 -18 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Mar 13, 2026
aduh95
approved these changes
Mar 13, 2026
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
Collaborator
addaleax
approved these changes
Mar 17, 2026
addaleax
pushed a commit
that referenced
this pull request
Mar 17, 2026
If the script passed to --eval starts with a hyphen, the CLI parser treats it as another option flag. Document the --eval=<script> form as the workaround and add tests for --eval=-42, --eval=-0, and the -e -p missing-argument error. Co-authored-by: jorge guerrero <[email protected]> Refs: #43397 Refs: #61962 PR-URL: #62244 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Member
|
Landed in 9e89867 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the script passed to
--evalstarts with a hyphen, the CLI parsertreats it as another option flag. Document the
--eval=<script>formas the workaround and add tests for
--eval=-42,--eval=-0, and the-e -pmissing-argument error.Refs: #43397
Continues the work from #61962
🤖 Generated with Claude Code